[PC-434] 가치관 talk ui 구현 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksowk156
added
UI/UX 🎨
tgyuuAn
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
ui를 확인해보니까 '프로필 생성' 이랑 '프로필' 이렇게 2개가 있는데, '프로필 생성'의 RegisterProfile이랑 '프로필'의 MainProfile이 같은 profile 모듈에 있는 것 같더라구요. 이거 모듈을 분리해야 될까요??
일단 profile 이라는 모듈 안에 같이 넣어두면 될 것 같습니다!
쓰다가 분리해야할 것 같이 커지면 분해하도록하죠!
++ 추가적으로 디스코드에 디자이너님들이 추가적인 요구사항이 있는 것 같아요!
그 부분 해결해주시고 머지하면 될 것 같습니다~
core/designsystem/src/main/java/com/puzzle/designsystem/component/TextFields.kt
Show resolved
Hide resolved
tgyuuAn
added
머지 해도될듯염🌟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. ⭐️ 변경된 내용
가치관 talk ui 구현
2. 🖼️ 스크린샷(선택)
KakaoTalk_20250129_200805968.mp4
3. 💡 알게된 부분
4. 📌 이 부분은 꼭 봐주세요!
ui를 확인해보니까 '프로필 생성' 이랑 '프로필' 이렇게 2개가 있는데, '프로필 생성'의 RegisterProfile이랑 '프로필'의 MainProfile이 같은 profile 모듈에 있는 것 같더라구요. 이거 모듈을 분리해야 될까요??